Conversation
jbelien
reviewed
Dec 14, 2020
Comment on lines
+23
to
+26
| <small> | ||
| You may see characters that shoudn't be here... Don't worry, they won't appear in the live | ||
| website! | ||
| </small> |
Contributor
There was a problem hiding this comment.
This part will be confusing ...
What kind of "characters that shoudn't be here" are we talking about ?
Contributor
There was a problem hiding this comment.
Oh okay, I think you're talking about the markdown formatting characters.
I would clarify that.
Something like "You will see formatting characters (* , #, ...) ...".
Or could you make the preview work like it works on the Stories page ?
Contributor
Author
There was a problem hiding this comment.
'Markers' are not shown in the excerpt of a story, it's just plaintext on the live website. Gatsby is using a tool to convert markdown into text (a plugin for remark, I think) but I didn't really look into it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds useful comments where the need is felt on the CMS side.